BUG: resample Grouper in a list grouping on a column with NaT throws an error #22470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22470 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 169 169
Lines 50769 50769
=======================================
Hits 46731 46731
Misses 4038 4038
Continue to review full report at Codecov.
|
jreback
requested changes
Aug 23, 2018
pandas/tests/test_resample.py
Outdated
| @@ -3175,6 +3175,15 @@ def test_median_duplicate_columns(self): | |||
| expected.columns = result.columns | |||
| assert_frame_equal(result, expected) | |||
|
|
|||
| def test_resample_list_grouper_with_nat(self): | |||
There was a problem hiding this comment.
can you test the case w/o a list as well
move test to pandas/tests/groupby/test_grouping.py
jreback
added
Testing
discort
force-pushed
the
list_grouper_resample
branch
from
c52a98d to
34dda28
Compare
jreback
approved these changes
Aug 28, 2018
|
thanks! |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff